The test task for interns #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PRIMARY KEY(id) | ||
| ); | ||
|
|
||
| INSERT INTO socks (color, cotton, quantity) |
There was a problem hiding this comment.
в идеальном мире к init относится только создание таблицы
а заполнение таблицы данными добавляется в другом скрипте
| id serial, | ||
| color text NOT NULL, | ||
| cotton int NOT NULL, | ||
| quantity int NOT NULL, |
There was a problem hiding this comment.
судя по структуре таблицы - quantity хранит в себе количество пар, хотя если удалить это поле из модели и добавлять quantity пар носков при приходе и удалять при отпуске, то не нужно будет вести сложную логику по изменению quantity и следить, чтобы каждый раз всякий, кто хочет написать код - менял это значение при отпуске/приходе пар носков
| @@ -0,0 +1,95 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
к сожалению Code review сделать не могу, тк надо было добавлять в репозиторий файлы, которые являются источниками кода и лежат в пакете src и не target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.